lkml.org 
[lkml]   [2015]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regmap: rbtree: When adding a reg do a bsearch for target node
On Wed, Oct 21, 2015 at 02:16:14PM +0100, Nikesh Oswal wrote:
> From: Nikesh Oswal <Nikesh.Oswal@wolfsonmicro.com>

If you are going to use your non-opensource email, might as well
use the cirrus one here.

>
> A binary search is much more efficient rather than iterating
> over the rbtree in ascending order which the current code is
> doing.
>
> During initialisation the reg defaults are written to the
> cache in a large chunk and these are always sorted in the
> ascending order so for this situation ideally we should have
> iterated the rbtree in descending order.
>
> But at runtime the drivers may write into the cache in any
> random order so this patch selects to use a bsearch to give
> an optimal runtime performance and also at initialisation
> time when reg defaults are written the performance of binary
> search would be much better than iterating in ascending order
> which the current code was doing.
>
> Signed-off-by: Nikesh Oswal <Nikesh.Oswal@wolfsonmicro.com>
> ---

Patch looks fine to me though:

Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles


\
 
 \ /
  Last update: 2015-10-22 11:21    [W:0.296 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site