lkml.org 
[lkml]   [2015]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask
From
Date
On Mon, 2015-10-12 at 05:38 -0700, David Miller wrote:
> From: Geliang Tang <geliangtang@163.com>
> Date: Fri, 9 Oct 2015 03:45:39 -0700
>
> > pcnet32 can't work on my machine recently. It says "architecture
> > does not support 32bit PCI busmaster DMA". There is a logic error
> > in it: pci_set_dma_mask() return 0 means return successfully.
> >
> > Signed-off-by: Geliang Tang <geliangtang@163.com>
>
> This driver doesn't call pci_set_dma_mask() in any of my tree(s).
I failed. My system with pcnet32 boards was down with a dead power
supply and a visual review was not good enough. I missed that
pci_dma_supported returns 1 on success and pci_set_dma_mask returns 0 on
success. The original patch needs to have the ! removed as Geliang Tang
points out.

Acked-by: Don Fry <pcnet32@frontier.com>



\
 
 \ /
  Last update: 2015-10-22 06:21    [W:0.074 / U:1.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site