Messages in this thread | | | Date | Thu, 22 Oct 2015 00:53:38 +0900 | Subject | Re: [PATCH v1 06/17] scsi :ufs: verify hba controller hce reg value | From | Akinobu Mita <> |
| |
2015-09-13 23:52 GMT+09:00 Yaniv Gardi <ygardi@codeaurora.org>: > Sometimes due to hw issues it takes some time to the > host controller register to update. In order to verify the register > has updated, a polling is done until its value is set. > > In addition the functions ufshcd_hba_stop() and > ufshcd_wait_for_register() was updated with an additional input > parameter, indicating the timeout between reads will > be done by sleeping or spinning the cpu. > > Signed-off-by: Raviv Shvili <rshvili@codeaurora.org> > Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> > > --- > drivers/scsi/ufs/ufshcd.c | 54 ++++++++++++++++++++++++++++------------------- > drivers/scsi/ufs/ufshcd.h | 12 +++-------- > 2 files changed, 35 insertions(+), 31 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 6171da8..e5a876c 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -267,11 +267,12 @@ static inline void ufshcd_disable_irq(struct ufs_hba *hba) > * @val - wait condition > * @interval_us - polling interval in microsecs > * @timeout_ms - timeout in millisecs > - * > + * @can_sleep - perform sleep or just spin > * Returns -ETIMEDOUT on error, zero on success > */
We usually put a blank line between @argument description and return value description.
| |