lkml.org 
[lkml]   [2015]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: change samples type to unsigned long long
Em Tue, Sep 29, 2015 at 02:49:43PM -0700, Yang Shi escreveu:
> When run "perf record -e", the number of samples showed up is wrong on some
> 32 bit systems, i.e. powerpc and arm.
>
> For example, run the below commands on 32 bit powerpc:
>
> perf probe -x /lib/libc.so.6 malloc
> perf record -e probe_libc:malloc -a ls
> perf.data
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.036 MB perf.data (13829241621624967218 samples) ]
>
> Actually, "perf script" just shows 21 samples. The number of samples is also
> absurd since samples is long type, but it is printed as PRIu64.
>
> Build test is run on x86-64, x86, aarch64, arm, mips, ppc and ppc64.

Sure?

AR /tmp/build/perf/libperf.a
builtin-record.c: In function ‘__cmd_record’:
builtin-record.c:689:12: error: comparison between signed and unsigned
integer expressions [-Werror=sign-compare]

- Arnaldo

> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> ---
> tools/perf/builtin-record.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 142eeb3..e54aa4c 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -49,7 +49,7 @@ struct record {
> int realtime_prio;
> bool no_buildid;
> bool no_buildid_cache;
> - long samples;
> + unsigned long long samples;
> };
>
> static int record__write(struct record *rec, void *bf, size_t size)
> --
> 2.0.2


\
 
 \ /
  Last update: 2015-10-02 21:21    [W:0.054 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site