Messages in this thread | | | Date | Fri, 2 Oct 2015 13:52:41 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range |
| |
On Fri, 2 Oct 2015, Felipe Balbi wrote:
> On Mon, Sep 21, 2015 at 05:01:10PM +0200, Peter Senna Tschudin wrote: > > msleep under 20ms can result in sleeping up to 20ms, which may not be > > intended. Replace msleep(5) by usleep_range(5000, 6000). > > > > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> > > good catch. I'd apply this straight away. Alan ?
It really doesn't matter. As long as the delay is at least 5 ms, it can be arbitrarily long. This won't hurt, and if it prevents automated tools from complaining then it's worthwhile.
Peter, a lot of the changes you have been making will also apply to the ehci-hcd driver. Do you want to update it as well? One caution: The style used for continuation lines is to add two extra tab stops, not to align things with an open paren on the original line.
Alan Stern
| |