lkml.org 
[lkml]   [2015]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/14] perf/bench/mem: Rename 'routine' to 'routine_str'
Em Mon, Oct 19, 2015 at 09:09:32PM +0200, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>
> > Em Mon, Oct 19, 2015 at 04:54:47PM -0200, Arnaldo Carvalho de Melo escreveu:
> > > Em Mon, Oct 19, 2015 at 07:34:46AM -0600, David Ahern escreveu:
> > > > On 10/19/15 2:04 AM, Ingo Molnar wrote:
> > > > >@@ -128,7 +128,7 @@ static void __bench_mem_routine(struct bench_mem_info *info, int r_idx, size_t l
> > > > > double result_bps = 0.0;
> > > > > u64 result_cycles = 0;
> > > > >
> > > > >- printf("Routine %s (%s)\n", r->name, r->desc);
> > > > >+ printf("routine %s (%s)\n", r->name, r->desc);
> > > > >
> > > > > if (bench_format == BENCH_FORMAT_DEFAULT)
> > > > > printf("# Copying %s Bytes ...\n\n", length_str);
> > > >
> > > > Seems like 'R' is more appropriate here.
> > >
> > > Right, changed it.
> >
> > And then, he does that on a later patch, duh.
>
> Yeah, indeed - I messed that up: tried to introduce __unused but noticed during
> development and testing on other distros that '__unused' is way too crowded a
> namespace (various fields in random headers are named like that), so after a bit
> of a fight with those headers I changed it back to __maybe_unused ... but the
> original change slipped into the series.
>
> Do you want me to resend the series to fix this and the other problems David and
> you noticed?

No problem, I fixed it all already :-)

- Arnaldo


\
 
 \ /
  Last update: 2015-10-19 21:41    [W:0.101 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site