Messages in this thread | | | Date | Mon, 19 Oct 2015 18:11:57 +0200 | From | Michael Büsch <> | Subject | Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0 |
| |
On Mon, 19 Oct 2015 17:02:23 +0100 Paul McQuade <paulmcquad@gmail.com> wrote:
> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c > index 058a9f2..086f0ba 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -2502,7 +2502,7 @@ static int lpphy_b2063_tune(struct b43_wldev *dev, > { > struct ssb_bus *bus = dev->dev->sdev->bus; > > - static const struct b206x_channel *chandata = NULL; > + static const struct b206x_channel *chandata; > u32 crystal_freq = bus->chipco.pmu.crystalfreq * 1000; > u32 freqref, vco_freq, val1, val2, val3, timeout, timeoutref, count; > u16 old_comm15, scale;
Why on earth is this static anyway? That seems really wrong here. The static should be removed (and the =NULL init be left in place.)
-- Michael [unhandled content-type:application/pgp-signature] | |