lkml.org 
[lkml]   [2015]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 39/39] Update the buildsystem for KConfig finding Qt
From
Date
On 2015-10-16 06:12, Stefan Lippers-Hollmann wrote:
> Hi
>
> On 2015-09-22, Thiago Macieira wrote:
>> The buildsystem will now only search for Qt 4 and Qt 5. Support for Qt 2
>> and 3 was dropped in the previous commits (Qt 3 was EOL'ed in 2010 or
>> so...).
>>
>> For Qt 5, to be future-proof with the future direction notice appearing
>> in the 5.5 release, C++11 support is automatically enabled.
> [...]
>> --- a/scripts/kconfig/Makefile
>> +++ b/scripts/kconfig/Makefile
> [...]
>> + @set -e; $(kecho) " CHECK qt"; \
>> + qtver=`qmake -query QT_VERSION` || { \
>> + echo >&2 "*"; \
>> + echo >&2 "* qmake failed."; \
>> + echo >&2 "*"; \
>> + exit 1; \
>> + }; \
> [...]
>
> "qmake -query QT_VERSION" appears to be a little fragile on Debian
> with both qt4-qmake and qt5-qmake installed, as it reports back
> "4.8.7" by default.

On openSUSE, I had to change qmake and moc to qmake-qt5 and moc-qt5,
respectively. But I don't think that it is a reason to call it fragile.
make xconfig works fine if qmake defaults to Qt4 (which seems to be the
predominant choice nowadays), but it will continue work once
distributions start preferring Qt5. I don't think users have such strong
preference as to which Qt version to build against. In the end, it's a
simple application with three windows and some buttons.

Michal


\
 
 \ /
  Last update: 2015-10-16 12:01    [W:0.216 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site