lkml.org 
[lkml]   [2015]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 7/7] Bluetooth: btqcomsmd: Qualcomm WCNSS HCI driver
    On Wed 14 Oct 08:10 PDT 2015, yfw wrote:

    [..]
    > > diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
    [..]
    > > +static int btqcomsmd_probe(struct qcom_smd_device *sdev)
    > > +{
    > > + struct qcom_smd_channel *acl;
    > > + struct btqcomsmd *btq;
    > > + struct hci_dev *hdev;
    > > + int ret;
    > > +
    > > + acl = qcom_smd_open_channel(sdev,
    > > + "APPS_RIVA_BT_ACL",
    > > + btqcomsmd_acl_callback);
    > > + if (IS_ERR(acl))
    > > + return PTR_ERR(acl);
    > Do we need to close acl channel in following failure path and
    > btqcomsmd_remove?
    >

    As the life cycle of the channels implicitly follow the life cycle of
    the qcom_smd_device the channel is supposed to be released by the
    caller of probe upon failure.

    I'll make sure this is documented in qcom_smd_open_channel()


    Thanks for the review.

    Regards,
    Bjorn


    \
     
     \ /
      Last update: 2015-10-14 23:01    [W:3.303 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site