lkml.org 
[lkml]   [2015]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] sched: fix task and run queue run_delay inconsistencies
    Date
    > On Thu, Oct 01, 2015 at 08:37:32AM +0200, Peter Zijlstra wrote:
    >
    > > > On Wed, Sep 30, 2015 at 08:28:41PM +0000, Meyer, Mike wrote:
    >
    > It looks like the sites in the wakeup path do indeed not get any additional
    > conditionals.
    >
    > > > My only comment is I am not sure about the naming of the flag
    > > > ENQUEUE_TEMP which implies (to me) the enqueue is temporary which
    > > > clearly it isn't. Maybe something like
    > DEQUEUE_MOVE/ENQUEUE_MOVE
    > > > would be a bit more descriptive of the use case.
    > >
    > > Yes, I ran out of creative juices, let me attempt a better name once
    > > I've woken up a bit.
    >
    > How about DEQUEUE_SAVE, ENQUEUE_RESTORE ? Ideally I'd wrap the whole
    > pattern into a helper but C isn't really supportive of pre+post patterns like
    > this.

    Sounds fine to me!

    Thanks again.


    \
     
     \ /
      Last update: 2015-10-01 18:21    [W:2.305 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site