lkml.org 
[lkml]   [2015]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 10/11] perf/x86/intel: Perform rotation on Intel CQM RMIDs
On Fri, Nov 14, 2014 at 09:15:11PM +0000, Matt Fleming wrote:
+ /*
> + * A reasonable upper limit on the max threshold is the number
> + * of lines tagged per RMID if all RMIDs have the same number of
> + * lines tagged in the LLC.
> + *
> + * For a 35MB LLC and 56 RMIDs, this is ~1.8% of the LLC.
> + */
> + __intel_cqm_max_threshold =
> + boot_cpu_data.x86_cache_size * 1024 / (cqm_max_rmid + 1);

Seeing how a percentage is without unit, the 35MB figure seems
pointless.

Also, why would a flat distribution be a good measure for 'empty'? I
would think that would in fact constitute in use.

Should we make this 1/16th of this figure or any other random fraction <
1 ?


\
 
 \ /
  Last update: 2015-01-07 13:21    [W:0.162 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site