lkml.org 
[lkml]   [2015]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3] staging: vt6656: removed erroneous else statement
On Sat, Jan 31, 2015 at 02:05:21PM -0500, Derrick Greenspan wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: else is not generally useful after a break or return
> 559: FILE: drivers/staging/vt6656/rxtx.c:559:
> return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
> } else {
>
> Signed-off-by: Derrick Greenspan <derrick.greenspan@knights.ucf.edu>
> ---
> Changes in v2:
> - Hopefully fixed whitespace!
> Changes in v3:
> - Fixed GCC compiler warning

I don't believe you really did fix that warning, as you still are
creating a variable in the middle of a function, which isn't allowed.

Just leave the existing code as-is, this is getting too messy.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-02-01 02:21    [W:0.031 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site