lkml.org 
[lkml]   [2015]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: sched: One function call less in em_meta_change() after error detection
    >> +exit:
    >> return err;
    >> }
    >
    > Why do you use that exit label if it does nothing more than returning
    > the error value? Also if nla_parse fails you dont use it but return the
    > error directly. While using a label which is used only to return an
    > error may be a matter of taste, its at least inconsistent to do both in
    > a function, use such a label in one case and return immediately in
    > another, isnt it?

    I find that all these cases correspond to the current Linux coding
    style documentation, doesn't it?

    Regards,
    Markus


    \
     
     \ /
      Last update: 2015-01-31 23:01    [W:2.553 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site