lkml.org 
[lkml]   [2015]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 31 Jan 2015 19:09:50 +0100

    The cipso_v4_doi_putdef() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    net/netlabel/netlabel_mgmt.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/netlabel/netlabel_mgmt.c b/net/netlabel/netlabel_mgmt.c
    index 8b3b789..f5807f5 100644
    --- a/net/netlabel/netlabel_mgmt.c
    +++ b/net/netlabel/netlabel_mgmt.c
    @@ -242,8 +242,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
    return 0;

    add_failure:
    - if (cipsov4)
    - cipso_v4_doi_putdef(cipsov4);
    + cipso_v4_doi_putdef(cipsov4);
    if (entry)
    kfree(entry->domain);
    kfree(addrmap);
    --
    2.2.2


    \
     
     \ /
      Last update: 2015-01-31 22:41    [W:4.034 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site