lkml.org 
[lkml]   [2015]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned
On Fri, 30 Jan 2015, Andi Kleen wrote:

> > We don't "need" any backward compatility, why not fix the broken drivers
> > that are using memory outside of what they are asking for? That's not
> > ok no matter what, right?
>
> How would you find them all?
>
> We don't even know which place in XHCI is the culprit here.

It shouldn't be too hard to find, expecially if the fault can easily
be reproduced.

There are only about half a dozen calls to dma_alloc_coherent in the
xhci-hcd driver. Just add 64 KB to the requested memory size in each
of them. Then one-by-one (or using bisection) remove the extra size
and see which spots trigger the fault.

Alan Stern



\
 
 \ /
  Last update: 2015-01-31 18:21    [W:0.074 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site