Messages in this thread | | | Date | Fri, 30 Jan 2015 10:22:12 +0100 | From | Paolo Bonzini <> | Subject | Re: [PATCH 0/8] KVM: minor APIC fixes and cleanups |
| |
On 29/01/2015 22:48, Radim Krčmář wrote: > This patch series is made our of three logical parts, > > [1-3/8] are just a cleanup and could be omitted > [4-6/8] improve broadcast detection and unoptimized delivery > [7-8/8] handle mixed mode (by falling back to improvements from [5-6/9])
I applied patches 1-4 and commented on patch 5.
I'm afraid that patches 7-8 could lead to missed optimizations in some cases.
Regarding patch 6, perhaps there's a way to avoid this:
+ /* XXX: A superset of x2APIC broadcasts is fine in practice as long as + * we don't support APIC ID > 0xfeffffff. + */
It's ugly. :)
Paolo
> > Radim Krčmář (8): > KVM: x86: return bool from kvm_apic_match*() > KVM: x86: cleanup kvm_apic_match_*() > KVM: x86: replace 0 with APIC_DEST_PHYSICAL > KVM: x86: fix x2apic logical address matching > KVM: x86: use MDA for interrupt matching > KVM: x86: allow mixed APIC mode broadcast > KVM: x86: avoid logical_map when it is invalid > KVM: x86: simplify kvm_apic_map > > arch/x86/include/asm/kvm_host.h | 4 +- > arch/x86/kvm/ioapic.h | 2 +- > arch/x86/kvm/lapic.c | 176 +++++++++++++++++++--------------------- > arch/x86/kvm/lapic.h | 35 ++++---- > 4 files changed, 106 insertions(+), 111 deletions(-) >
| |