Messages in this thread | | | Date | Thu, 29 Jan 2015 14:26:17 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used |
| |
On 28/01/15 22:35, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/staging/comedi/drivers/jr3_pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/jr3_pci.c b/drivers/staging/comedi/drivers/jr3_pci.c > index 81fab2d..5d4cca7 100644 > --- a/drivers/staging/comedi/drivers/jr3_pci.c > +++ b/drivers/staging/comedi/drivers/jr3_pci.c > @@ -520,10 +520,9 @@ static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice > result = poll_delay_min_max(20, 100); > } else { > /* Set full scale */ > - struct six_axis_t min_full_scale; > struct six_axis_t max_full_scale; > > - min_full_scale = get_min_full_scales(channel); > + get_min_full_scales(channel); > max_full_scale = get_max_full_scales(channel); > set_full_scales(channel, max_full_scale); > >
Yes, it doesn't appear to be needed. The driver used to have some kernel logs that output the min and max full scale information, but it didn't do anything else with min_full_scale.
The call to get_min_full_scales() and the function itself can also be removed.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |