lkml.org 
[lkml]   [2015]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000
On 29/01/15 07:44, Ingo Molnar wrote:

Hi Ingo.

I'll transmit those changes in with the following exception

>> + ret = imr_write(idev, reg, &imr, false);
>
> So 'ret' here gets mixed with other potential failure modes.
>
> If imr_write() fails here then that's a highly anomalous internal
> failure - so it might be better to add a WARN_ON(ret) or so.
>

imr_write() already does a WARN - so no need to do it again.


\
 
 \ /
  Last update: 2015-01-29 14:41    [W:0.189 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site