Messages in this thread | | | Date | Thu, 29 Jan 2015 13:27:20 +0000 | From | Bryan O'Donoghue <> | Subject | Re: [PATCH 1/2] x86: Add Isolated Memory Regions for Quark X1000 |
| |
On 29/01/15 07:44, Ingo Molnar wrote:
Hi Ingo.
I'll transmit those changes in with the following exception
>> + ret = imr_write(idev, reg, &imr, false); > > So 'ret' here gets mixed with other potential failure modes. > > If imr_write() fails here then that's a highly anomalous internal > failure - so it might be better to add a WARN_ON(ret) or so. >
imr_write() already does a WARN - so no need to do it again.
| |