Messages in this thread | | | Subject | Re: [PATCHv2 0/8] Fix perf probe issues on powerpc | From | Michael Ellerman <> | Date | Fri, 30 Jan 2015 13:19:38 +1100 |
| |
On Wed, 2015-01-28 at 12:13 +0530, Naveen N. Rao wrote: > On 2015/01/28 05:14PM, Michael Ellerman wrote: > > On Wed, 2015-01-28 at 11:12 +0530, Naveen N. Rao wrote: > > > On 2014/12/15 08:20PM, Naveen N Rao wrote: > > > > This patchset fixes various issues with perf probe on powerpc across ABIv1 and > > > > ABIv2: > > > > - in the presence of DWARF debug-info, > > > > - in the absence of DWARF, but with the symbol table, and > > > > - in the absence of debug-info, but with kallsyms. > > > > > > > > Applies cleanly on -tip. Tested on ppc64 BE and LE. > > > > > > > > Changes from previous version: > > > > Addressed various review comments from Mike Ellerman largely to generalize > > > > changes. Some of the simpler patches have been retained in their previous form > > > > to limit code churn, while others have been generalized by introducing arch > > > > helpers. Individual patches have more details. > > > > > > Michael, > > > Can you please take a quick look at this? > > > > I merged patch 1. > > > > https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/commit/?h=next&id=bf794bf52a80c6278a028f0af2ca32d7c3508c9b > > > > The rest are not for me, they're perf tools, so you need to convince acme > > they're good. > > Oh, thanks! Sorry, I didn't realize you had already merged it. > I assume you are ok with my changes in v2 w.r.t your previous review > comments.
Yeah it looks like you addressed most of my comments.
cheers
| |