lkml.org 
[lkml]   [2015]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/12] time: Add debugging checks to warn if we see delays
On Thu, Jan 22, 2015 at 04:09:20PM -0800, John Stultz wrote:
> +#ifdef CONFIG_DEBUG_TIMEKEEPING
> +static void timekeeping_check_update(struct timekeeper *tk, cycle_t offset)
> +{
> +
> + cycle_t max_cycles = tk->tkr.clock->max_cycles;
> + const char *name = tk->tkr.clock->name;
> +
> + if (offset > max_cycles)
> + printk_deferred("ERROR: cycle offset (%lld) is larger then"
> + " allowed %s max_cycles (%lld)\n",
> + offset, name, max_cycles);
> + else if (offset > (max_cycles >> 1))
> + printk_deferred("WARNING: cycle offset (%lld) is past"
> + " the %s 50%% safety margin (%lld)\n",
> + offset, name, max_cycles>>1);
> +}
> +#else
> +#define timekeeping_check_update(x, y)

static inline void timekeeping_check_update(struct timekeeper *tk, cycle_t offset) { }

Would preserve argument type checks. The only argument for using a macro
here would be to avoid evaluating the arguments, but that's not an issue
in this case afaict.

> +#endif


\
 
 \ /
  Last update: 2015-01-23 15:41    [W:0.326 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site