Messages in this thread | | | Date | Thu, 22 Jan 2015 15:16:32 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH 2/2] drivers/hwmon/adc128d818.c: Do proper sign extension |
| |
On 01/22/2015 02:44 PM, Rasmus Villemoes wrote: > data->temp[index] has type s16. Because of C's promotion rules, > (data->temp[index] << 7) >> 7 is exactly the same as > data->temp[index]. The intention was to use bit 8 as a sign bit, so do > that using the existing API. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > ---
Applied.
Thanks, Guenter
| |