Messages in this thread Patch in this message | | | From | Dudley Du <> | Subject | [PATCH 2/2] input: cyapa: fix variable dereferenced before check 'gen5_pip->resp_len' issue | Date | Thu, 22 Jan 2015 14:50:06 +0800 |
| |
Fixes the warning issue of the variable dereferenced before check 'gen5_pip->resp_len' report by dan Carpenter.
Signed-off-by: Dudley Du <dudl@cypress.com> --- drivers/input/mouse/cyapa_gen5.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c index 69d9059..ed1af74 100644 --- a/drivers/input/mouse/cyapa_gen5.c +++ b/drivers/input/mouse/cyapa_gen5.c @@ -2558,7 +2558,9 @@ static bool cyapa_gen5_irq_cmd_handler(struct cyapa *cyapa) * trackpad device when booting/rebooting * their chrome book. */ - length = *gen5_pip->resp_len; + length = 0; + if (gen5_pip->resp_len) + length = *gen5_pip->resp_len; cyapa_empty_pip_output_data(cyapa, gen5_pip->resp_data, &length, -- 1.9.1
| |