lkml.org 
[lkml]   [2015]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] of: Custom printk format specifier for device node
From
Date
On Wed, 2015-01-21 at 19:39 +0200, Pantelis Antoniou wrote:
> Hi Joe,
>
> > On Jan 21, 2015, at 19:37 , Joe Perches <joe@perches.com> wrote:
> >
> > On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote:
> >> 90% of the usage of device node's full_name is printing it out
> >> in a kernel message. Preparing for the eventual delayed allocation
> >> introduce a custom printk format specifier that is both more
> >> compact and more pleasant to the eye.
> >>
> >> For instance typical use is:
> >> pr_info("Frobbing node %s\n", node->full_name);
> >>
> >> Which can be written now as:
> >> pr_info("Frobbing node %pO\n", node);
> >
> > Still disliking use of %p0.
> >
>
> Choices are limited. And it’s pO not p0.

Yet another reason to dislike it.

> > This isn't pretty. Perhaps there's a better way?
> >
>
> No there isn’t.

There always is.




\
 
 \ /
  Last update: 2015-01-21 19:01    [W:0.069 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site