Messages in this thread | | | Subject | Re: [PATCH] of: Custom printk format specifier for device node | From | Joe Perches <> | Date | Wed, 21 Jan 2015 09:52:07 -0800 |
| |
On Wed, 2015-01-21 at 19:39 +0200, Pantelis Antoniou wrote: > Hi Joe, > > > On Jan 21, 2015, at 19:37 , Joe Perches <joe@perches.com> wrote: > > > > On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote: > >> 90% of the usage of device node's full_name is printing it out > >> in a kernel message. Preparing for the eventual delayed allocation > >> introduce a custom printk format specifier that is both more > >> compact and more pleasant to the eye. > >> > >> For instance typical use is: > >> pr_info("Frobbing node %s\n", node->full_name); > >> > >> Which can be written now as: > >> pr_info("Frobbing node %pO\n", node); > > > > Still disliking use of %p0. > > > > Choices are limited. And it’s pO not p0.
Yet another reason to dislike it.
> > This isn't pretty. Perhaps there's a better way? > > > > No there isn’t.
There always is.
| |