Messages in this thread | | | Date | Wed, 21 Jan 2015 11:44:35 +0100 | Subject | Re: [PATCH v2 08/11] mmc: pwrseq_simple: Add support for a delay | From | Ulf Hansson <> |
| |
On 15 January 2015 at 18:33, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 01/15/2015 09:12 AM, Tomeu Vizoso wrote: >> >> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> > > > Ah, having read the explanation in the next patch, I think ... > >> diff --git a/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt >> b/Documentation/devicetree/bindings/mmc/mmc,pwrseq-simple.txt > > >> +- delay : delay to wait after driving the reset gpio active [ms]. > > > ... delay is the wrong name. reset-pulse-width or reset-pulse-length would > be better. delay sounds like a delay after resetting the device before it > can be accessed.
I agree with Stephen's proposal.
This patch needs to be rebased and retested on latest version the mmc-pwrseq patches. Moreover, if you think the patchset which $subject patch is a part of is material for 3.20, I will need to share an immutable branch with the mmc-pwrseq patches for ARM SOC to pull in, tell me if you need that.
Kind regards Uffe
| |