Messages in this thread | | | Date | Fri, 2 Jan 2015 06:11:11 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 0/3] mm: cma: /proc/cmainfo |
| |
On Mon 2014-12-29 11:36:39, Minchan Kim wrote: > Hello, > > On Fri, Dec 26, 2014 at 05:39:01PM +0300, Stefan I. Strogin wrote: > > Hello all, > > > > Here is a patch set that adds /proc/cmainfo. > > > > When compiled with CONFIG_CMA_DEBUG /proc/cmainfo will contain information > > about about total, used, maximum free contiguous chunk and all currently > > allocated contiguous buffers in CMA regions. The information about allocated > > CMA buffers includes pid, comm, allocation latency and stacktrace at the > > moment of allocation.
We should not add new non-process related files in /proc. So... NAK. Should this go to debugfs instead?
> It just says what you are doing but you didn't say why we need it. > I can guess but clear description(ie, the problem what you want to > solve with this patchset) would help others to review, for instance, > why we need latency, why we need callstack, why we need new wheel > rather than ftrace and so on. > > Thanks. > > > > > Example: > > > > # cat /proc/cmainfo > > CMARegion stat: 65536 kB total, 248 kB used, 65216 kB max contiguous chunk
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |