Messages in this thread | | | From | Ricardo Ribalda Delgado <> | Date | Tue, 20 Jan 2015 00:10:34 +0100 | Subject | Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove |
| |
Hello Peter
> > > - hwirq = irq_of_parse_and_map(np, 0); > > - if (hwirq == NO_IRQ) > > + mpc8xxx_gc->irqn = irq_of_parse_and_map(np, 0); > > + if (mpc8xxx_gc->irqn == NO_IRQ) > > return 0; > > > With this return 0 converted to do of_mm_gpiochip_remove():
Are you sure? The driver can still work as a normal gpio without the irq domain part and the remove function consider this option. The original code did also continue....
If you still want to abort if no irq I can of course make the change.
Regards!
> > Acked-by: Peter Korsgaard <peter@korsgaard.com> > > -- > Bye, Peter Korsgaard
Regards
-- Ricardo Ribalda
| |