Messages in this thread | | | Date | Mon, 19 Jan 2015 16:02:10 +0530 | From | Archit Taneja <> | Subject | Re: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x |
| |
Hi,
On 01/17/2015 03:26 AM, Stephen Boyd wrote: > On 01/16/2015 06:48 AM, Archit Taneja wrote: >> The NAND controller within EBI2 requires EBI2_CLK and EBI2_ALWAYS_ON_CLK clocks. >> Create structs for these clocks so that they can be used by the NAND controller >> driver. Add an entry for EBI2_AON_CLK in the gcc-ipq806x DT binding document. >> >> Cc: Stephen Boyd <sboyd@codeaurora.org> >> Signed-off-by: Archit Taneja <architt@codeaurora.org> > > Looks ok. I couldn't find this used in the downstream sources though. > Can you point me to it? I'm mostly worried that this is a shared > resource that never should be turned off, so exposing it to drivers may > not be the right idea.
I'll share the sources.
> >> +static struct clk_branch ebi2_aon_clk = { >> + .hwcg_reg = 0x3b00, >> + .hwcg_bit = 6, >> + .halt_reg = 0x2fcc, >> + .halt_bit = 0, >> + .clkr = { >> + .enable_reg = 0x3b00, >> + .enable_mask = BIT(8), >> + .hw.init = &(struct clk_init_data){ >> + .name = "ebi2_always_on_clk", >> > > Can this be ebi2_aon_clk to match the macro? >
I'll fix this.
Thanks, Archit
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |