Messages in this thread | | | From | 敬锐 <> | Subject | Re: [PATCH 09/10] mfd: rtsx: add support for rts525A | Date | Mon, 19 Jan 2015 02:53:49 +0000 |
| |
On 01/18/2015 07:13 PM, Lee Jones wrote: >> @@ -97,7 +97,7 @@ static void rts5249_force_power_down(struct rtsx_pcr *pcr, u8 pm_state) >> > rtsx_pci_write_register(pcr, AUTOLOAD_CFG_BASE + 3, 0x01, 0); >> > >> > if (pm_state == HOST_ENTER_S3) { >> >- if (PCI_PID(pcr) == 0x524A) >> >+ if (PCI_PID(pcr) == 0x524A || PCI_PID(pcr) == 0x525A) > Shouldn't these be defined somewhere? > > I have a particular distaste for magic numbers. > This is the chip ID number, no need define, just using it. if we define, it will like RTS525A_PCI_ID, so bad.
| |