Messages in this thread | | | Subject | Re: [PATCH] checkpatch: add check for the buggy while_each_thread() | From | Joe Perches <> | Date | Sun, 18 Jan 2015 17:27:33 -0800 |
| |
On Sun, 2015-01-18 at 17:24 +0300, Sergey Dyasly wrote: > Now it's preferable to use for_each_thread() instead of while_each_thread(). > Add a check to checkpatch.pl in order to prevent any new usages of the buggy > while_each_thread() when possible. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -3255,6 +3255,12 @@ sub process { > "Prefer dev_$level(... to dev_printk(KERN_$orig, ...\n" . $herecurr); > } > > +# Check for the buggy while_each_thread() > + if ($line =~ /\bwhile_each_thread\(/) {
\bwhile_each_thread\s*\( or maybe \bwhile_each_thread\b
> + WARN("WHILE_EACH_THREAD", > + "Prefer to use for_each_thread() instead of the buggy while_each_thread(). See commit 0c740d0afc3bff0a097ad03a1c8df92757516f5c for details.\n" . $herecurr);
Pretty long commit id, 12 is probably enough.
| |