lkml.org 
[lkml]   [2015]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id function
Date
Hi Greg,

Thanks for your review.

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Sunday, January 18, 2015 8:04 AM
> To: Tang, Feng
> Cc: One Thousand Gnomes; John Stultz; Colin Cross; Heesub Shin; Mitchel
> Humpherys; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id
> function
>
> > >
> > > On Sun, 4 Jan 2015 15:11:51 +0800
> > > Feng Tang <feng.tang@intel.com> wrote:
> > >
> > > > There is user case that user only knows the ion_handle idand
> > > > needs to get the physical addr and len. So add this wrapper to
> > > > meet this requirement.
> > >
> > > What is the in-tree upstream user of this new function ? I don't see one
> > > in your patches ?
> >
> > That's true. We are working on enabling a new platform which heavily
> > uses ION and some driver needs to use this API, so I guess there is some
> > other plaforms may have the similar requirements. If you think this patch
> > should be merged after there is an in-tree user, I'm OK with it :)
> >
> > I assume that driver's author will start to push his drivers in batch soon.
>
> We need to see those patches first, we can't add apis for no in-tree
> user, otherwise they will just get ripped out.
I see. I'll repost this patch after our "user" driver get merged.

How about the 2/2 patch, which improve the profiling info through
debugfs?
[PATCH 2/2] staging: android: ion: Add pss info for each ion_client

Thanks,
Feng



\
 
 \ /
  Last update: 2015-01-19 02:21    [W:0.069 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site