Messages in this thread | | | Date | Sun, 18 Jan 2015 11:12:36 -0800 | From | Darren Hart <> | Subject | Re: [PATCH] asus-laptop: is_visible should not return a bool |
| |
On Fri, Jan 16, 2015 at 09:29:19AM -0500, Vivien Didelot wrote: > With a Lucid platform, asus_sysfs_is_visible() returns a boolean for > ls_switch and ls_level attributes. Fix that and also s/supported/ok/ and > s/asus->handle/handle/ to avoid lines wider than 80 chars.
This is two patches, a cleanup and functional change. Since the cleanup has nothing to do with the cleanup, please split these out.
"ok" is an atypical variable name. It looks as though "ret" would server just as well and is far more consistent with typical usage.
-- Darren Hart Intel Open Source Technology Center
| |