Messages in this thread | | | From | Andrew Milkovich <> | Date | Sat, 17 Jan 2015 19:01:41 -0800 | Subject | Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors |
| |
Hi,
On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr > > comment is implied by the first argument being the channel. No parent bus > > comment is already understood by the argument being NULL. > > > > Signed-off-by: Andrew Milkovich <amilkovich@gmail.com> > > --- > > drivers/staging/unisys/virtpci/virtpci.c | 24 ++++++++---------------- > > 1 file changed, 8 insertions(+), 16 deletions(-) > > This doesn't apply to my staging-testing branch at all, sorry. > > greg k-h
Processing the patch with 'git apply' complains about a corruption; this is due to the fact that I ran cleanfile on the patch. The checkpatch.pl script was giving errors about trailing whitespace. I ran cleanpatch, errors still showed up, I ran cleanfile and it passed.
Using 'patch -p1 < patchname' seems to work.
I can resubmit the patch but for 'git apply' to work it will be failing the checkpatch.pl script. What should I do in this case?
Andrew Milkovich
| |