lkml.org 
[lkml]   [2015]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] dmaengine: of: bail out early if "dmas" property is not present
Date
Hi Wolfram,

Thank you for the patch.

On Wednesday 14 January 2015 15:16:28 Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> And don't print an error: not configured is not an error.
>
> Reported-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

This looks good to me.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>
> In response to Philipp's patch silencing the warning in the driver:
> http://patchwork.ozlabs.org/patch/425696/
>
> I think this should be handled in the core.
>
> drivers/dma/of-dma.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c
> index d5fbeaa1e7ba..ca31f1b45366 100644
> --- a/drivers/dma/of-dma.c
> +++ b/drivers/dma/of-dma.c
> @@ -159,6 +159,10 @@ struct dma_chan *of_dma_request_slave_channel(struct
> device_node *np, return ERR_PTR(-ENODEV);
> }
>
> + /* Silently fail if there is not even the "dmas" property */
> + if (!of_find_property(np, "dmas", NULL))
> + return ERR_PTR(-ENODEV);
> +
> count = of_property_count_strings(np, "dma-names");
> if (count < 0) {
> pr_err("%s: dma-names property of node '%s' missing or empty\n",

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2015-01-16 00:41    [W:0.071 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site