lkml.org 
[lkml]   [2015]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] gpio: max732x: Rewrite IRQ code to use irq_domain API
From
On Tue, Jan 13, 2015 at 2:41 PM, Semen Protsenko
<semen.protsenko@globallogic.com> wrote:

> Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>

This makes the code *so* much better so patch applied, naturally.

But...

> config GPIO_MAX732X
> tristate "MAX7319, MAX7320-7327 I2C Port Expanders"
> depends on I2C
> + select IRQ_DOMAIN

The most modern way would be to take another step and convert the
driver to GPIOLIB_IRQCHIP by stating

select GPIOLIB_IRQCHIP

here.

If you look at other drivers using GPIOLIB_IRQCHIP on an
i2c expander, say gpio-stmpe.c or gpio-tc3589x.c, you
can get a grip on how that works.

So please follow up with a patch converting the driver to
GPIOLIB_IRQCHIP on top of these patches :) if you
have time.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-01-15 18:21    [W:0.053 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site