lkml.org 
[lkml]   [2015]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v12 18/20] dax: Add dax_zero_page_range
    From
    Date
    On Mon, 2015-01-12 at 15:10 -0800, Andrew Morton wrote:
    > On Fri, 24 Oct 2014 17:20:50 -0400 Matthew Wilcox <matthew.r.wilcox@intel.com> wrote:
    >
    > > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
    > > [ported to 3.13-rc2]
    > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
    >
    > I never know what this means :(
    >
    > I switched it to
    >
    > [ross.zwisler@linux.intel.com: ported to 3.13-rc2]
    > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
    > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>

    The way that you've interpreted it is correct. Thanks!

    - Ross

    > but perhaps that was wrong?
    >
    >
    >
    >
    > also, coupla typos:
    >
    >
    > diff -puN fs/dax.c~dax-add-dax_zero_page_range-fix fs/dax.c
    > --- a/fs/dax.c~dax-add-dax_zero_page_range-fix
    > +++ a/fs/dax.c
    > @@ -475,7 +475,7 @@ EXPORT_SYMBOL_GPL(dax_fault);
    > * block_truncate_page(), but we could go down to PAGE_SIZE if the filesystem
    > * took care of disposing of the unnecessary blocks. Even if the filesystem
    > * block size is smaller than PAGE_SIZE, we have to zero the rest of the page
    > - * since the file might be mmaped.
    > + * since the file might be mmapped.
    > */
    > int dax_zero_page_range(struct inode *inode, loff_t from, unsigned length,
    > get_block_t get_block)
    > @@ -514,13 +514,13 @@ EXPORT_SYMBOL_GPL(dax_zero_page_range);
    > * @get_block: The filesystem method used to translate file offsets to blocks
    > *
    > * Similar to block_truncate_page(), this function can be called by a
    > - * filesystem when it is truncating an DAX file to handle the partial page.
    > + * filesystem when it is truncating a DAX file to handle the partial page.
    > *
    > * We work in terms of PAGE_CACHE_SIZE here for commonality with
    > * block_truncate_page(), but we could go down to PAGE_SIZE if the filesystem
    > * took care of disposing of the unnecessary blocks. Even if the filesystem
    > * block size is smaller than PAGE_SIZE, we have to zero the rest of the page
    > - * since the file might be mmaped.
    > + * since the file might be mmapped.
    > */
    > int dax_truncate_page(struct inode *inode, loff_t from, get_block_t get_block)
    > {
    > diff -puN include/linux/fs.h~dax-add-dax_zero_page_range-fix include/linux/fs.h
    > _
    >
    >
    > akpm3:/usr/src/linux-3.19-rc4> grep -r mmaped .| wc -l
    > 70
    > akpm3:/usr/src/linux-3.19-rc4> grep -r mmapped .| wc -l
    > 107
    >
    > lol.





    \
     
     \ /
      Last update: 2015-01-13 00:41    [W:5.856 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site