Messages in this thread | | | Date | Sun, 11 Jan 2015 05:31:08 -0800 | From | Jeremiah Mahler <> | Subject | Re: [RESEND PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk |
| |
Johan,
On Sun, Jan 11, 2015 at 12:36:18PM +0100, Johan Hovold wrote: > On Sat, Jan 10, 2015 at 04:44:32PM -0800, Jeremiah Mahler wrote: > > If a USB serial device is unplugged while there is an active program > > using the device it will spam the logs with -EPROTO (71) messages as it > > attempts to retry. > > Can you change this to "might spam", as which error message, and if it is > at all printed, depends on host controller and what (hub) devices are > used. > Ah, yes, good point.
> > Most serial usb drivers (metro-usb, pl2303, mos7840, ...) only output > > these messages for debugging. The generic driver treats these as > > errors. > > > > Change the default output for the generic serial driver from error to > > debug. > > Please also correct the commit summary (Subject) so that it matches what > this revised patch now does (you silence all non-critical error > messages). > True, it is more than just -EPROTO now.
> Fix this up and I'll take both patches. > > Thanks, > Johan
Thanks for the suggestions.
v3 coming up.
-- - Jeremiah Mahler
| |