lkml.org 
[lkml]   [2014]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3 1/3] [media] disable OMAP1 COMPILE_TEST
    Thanks, Mauro,

    On Tue, 9 Sep 2014, Mauro Carvalho Chehab wrote:

    > This driver depends on a legacy OMAP DMA API. So, it won't
    > compile-test on other archs.
    >
    > While we might add stubs to the functions, this is not a
    > good idea, as the hole API should be replaced.
    >
    > So, for now, let's just remove COMPILE_TEST and wait for
    > some time for people to fix. If not fixed, then we'll end
    > by removing this driver as a hole.
    >
    > Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

    Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

    Regards
    Guennadi

    >
    > diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/media/platform/soc_camera/Kconfig
    > index 6af6c6dccda8..f2776cd415ca 100644
    > --- a/drivers/media/platform/soc_camera/Kconfig
    > +++ b/drivers/media/platform/soc_camera/Kconfig
    > @@ -63,7 +63,7 @@ config VIDEO_SH_MOBILE_CEU
    > config VIDEO_OMAP1
    > tristate "OMAP1 Camera Interface driver"
    > depends on VIDEO_DEV && SOC_CAMERA
    > - depends on ARCH_OMAP1 || COMPILE_TEST
    > + depends on ARCH_OMAP1
    > depends on HAS_DMA
    > select VIDEOBUF_DMA_CONTIG
    > select VIDEOBUF_DMA_SG
    > --
    > 1.9.3
    >


    \
     
     \ /
      Last update: 2014-09-09 23:21    [W:0.021 / U:10.464 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site