lkml.org 
[lkml]   [2014]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] perf/x86/intel: Add Haswell-EP uncore support
On Thu, Sep 04, 2014 at 10:19:28AM +0200, Peter Zijlstra wrote:
> On Fri, Aug 22, 2014 at 07:29:26AM +0200, Andi Kleen wrote:
> > > diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> > > index 4785ee8..2485fd9 100644
> > > --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> > > +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> > > @@ -883,6 +883,8 @@ static int __init uncore_pci_init(void)
> > > case 62: /* Ivy Bridge-EP */
> > > ret = ivbep_uncore_pci_init();
> > > break;
> > > + case 63: /* Haswell-EP */
> > > + ret = hswep_uncore_pci_init();
> >
> > Is the lack of break intentional? If yes please add a /* FALL THROUGH */
> > comment.
>
> This does look inconsistent with the surrounding code, which does
> suggest it was indeed an oversight and not on purpose.
>
> Zheng?

Yes it was a bug. Zheng left Intel and I have taken over the driver.
I'll send a version with this and some other issues fixed shortly.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2014-09-04 18:21    [W:0.945 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site