Messages in this thread | | | Date | Thu, 4 Sep 2014 11:21:35 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v4 01/11] cpumask: factor out show_cpumap into separate helper function |
| |
On Thu, Sep 04, 2014 at 10:03:25AM +0100, Sudeep Holla wrote: > If I don't, every file including this header generates "warning: > ‘cpumap_copy_to_buf’ defined but not used". Alternatively I can just > declare here and define it elsewhere but I could not find more apt > place than this. Any suggestions ? kernel/cpu.c ?
Sure the tail of cpu.c seems to have various other cpumask gunk in already so it fits there. The other alternative would've been lib/bitmap.c since that's where the various bitmap printf implementations live.
You could make it bitmap_copy_to_buf() I suppose, and then have a cpumask inline wrapper, to be fully consistent with the rest of the implementations. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |