lkml.org 
[lkml]   [2014]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/9] ARM: vf610: Suspend/resume support
    On Mon, Sep 22, 2014 at 07:09:21PM +0200, Stefan Agner wrote:
    > This patchset provides suspend/resume support for Freescale Vybrid
    > SoC (vf610). The code is generally aligned to the implementation
    > for i.MX6. The subsystems SRC and GPC need some changes to support
    > the Vybrid specific implementation.
    >
    > This patchset relies on GPIO driver to be present (in order to
    > provide a wakeup source) as well as using the ARM Global Timer
    > clock source (the Vybrid specifc PIT clock source, vf_pit_timer.c
    > does not support shutdown).
    >
    > The implemented sleep states (LP-RUN and STOP), are not the most
    > power saving functions available on Vybrid. Especially for
    > suspend-to-memory one of the LPSTOP modes looks more appropriate.
    > However, the complexity is somewhat higher (we would need to move
    > execution path to SRAM and store IOMUX and DDRMC configuration).
    > Currently, I have not the resources to look into that so I hope
    > that this initial code qualifies as power saving functions to be
    > applied.

    So you have quite a lot of unnecessary code which is only needed by
    suspend from SRAM (store IOMUX and DDRMC configuration).

    Not happy with that.

    Shawn


    \
     
     \ /
      Last update: 2014-09-28 05:21    [W:2.843 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site