Messages in this thread | | | Date | Fri, 26 Sep 2014 10:37:39 +0200 | Subject | Re: [PATCH v2] pinctrl: qcom: use restart_notifier mechanism for ps_hold | From | Linus Walleij <> |
| |
On Tue, Sep 23, 2014 at 10:59 PM, Josh Cartwright <joshc@codeaurora.org> wrote:
> By converting to the restart_notifier mechanism for restart, we allow > for other mechanisms, like the watchdog, to be used for restart in the > case where PS_HOLD has failed to reset the chip. > > Since this mechanism may be one of several mechanisms registered, change > the post-ps_hold write timeout to be a more reasonable 1 second instead > of 10 seconds. > > Choose priority 128, as according to documentation, this mechanism "is > sufficient to restart the entire system". > > Cc: Pramod Gurav <pramod.gurav@smartplayin.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Tested-by: Pramod Gurav <pramod.gurav@smartplayin.com> > Signed-off-by: Josh Cartwright <joshc@codeaurora.org> > --- > > Changes since v1: > - Simplified conditional notifier block registration > - Reduced wait time to 1s, which I've found to be sufficient on an IFC6410 > board.
Patch applied with ACKs.
Yours, Linus Walleij
| |