Messages in this thread | | | Date | Thu, 25 Sep 2014 16:53:22 -0700 | From | Brian Norris <> | Subject | Re: [PATCH] of: correct of_console_check()'s return value |
| |
Hi Grant,
On Mon, Sep 08, 2014 at 11:42:38AM +0100, Grant Likely wrote: > On Wed, 3 Sep 2014 11:06:43 -0700, Brian Norris <computersforpeace@gmail.com> wrote: > > The comments above of_console_check() say that it will return TRUE if it > > registers a preferred console, but add_preferred_console() uses a > > 0-equals-success convention, so ths leaves of_console_check() with an > > inconsistent policy for its return values. > > > > Fortunately, nobody was actually checking the return value of > > of_console_check(), so this isn't significant at the moment. > > > > But let's match the comments, so we're doing what we say. > > > > Fixes: 3482f2c52b77 ('of: Create of_console_check() for selecting a console specified in /chosen') > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > > Cc: Grant Likely <grant.likely@linaro.org> > > Good catch. Applied, thanks.
Applied to what? I don't see it in linux-next.
Regards, Brian
| |