Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 12/22] cpuidle: Replace strnicmp with strncasecmp | Date | Fri, 26 Sep 2014 01:52:53 +0200 |
| |
On Tuesday, September 16, 2014 10:51:26 PM Rasmus Villemoes wrote: > The kernel used to contain two functions for length-delimited, > case-insensitive string comparison, strnicmp with correct semantics > and a slightly buggy strncasecmp. The latter is the POSIX name, so > strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper > for the new strncasecmp to avoid breaking existing users. > > To allow the compat wrapper strnicmp to be removed at some point in > the future, and to avoid the extra indirection cost, do > s/strnicmp/strncasecmp/g. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Queued up for 3.18, thanks!
> --- > drivers/cpuidle/governor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c > index ca89412..fb9f511 100644 > --- a/drivers/cpuidle/governor.c > +++ b/drivers/cpuidle/governor.c > @@ -28,7 +28,7 @@ static struct cpuidle_governor * __cpuidle_find_governor(const char *str) > struct cpuidle_governor *gov; > > list_for_each_entry(gov, &cpuidle_governors, governor_list) > - if (!strnicmp(str, gov->name, CPUIDLE_NAME_LEN)) > + if (!strncasecmp(str, gov->name, CPUIDLE_NAME_LEN)) > return gov; > > return NULL; >
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |