Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [RFC PATCH 4/4] ARM: dts: k2hk-evm: add pm domains for net, qmss and knav_dmas | Date | Thu, 25 Sep 2014 15:27:30 -0700 |
| |
Grygorii Strashko <grygorii.strashko@ti.com> writes:
> Add Keystone PM domains nodes for NetCP, NetCPx, QMSS, KNAV-DMA > devices. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > arch/arm/boot/dts/k2hk-evm.dts | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm/boot/dts/k2hk-evm.dts b/arch/arm/boot/dts/k2hk-evm.dts > index 91371f7..a7b468c 100644 > --- a/arch/arm/boot/dts/k2hk-evm.dts > +++ b/arch/arm/boot/dts/k2hk-evm.dts > @@ -58,6 +58,13 @@ > clock-output-names = "refclk-ddr3b"; > }; > }; > + > + qmss_domain: qmss_pm_controller { > + compatible = "ti,keystone-gpc"; > + clocks = <&chipclk13>; > + #power-domain-cells = <0>; > + };
Hmm, I'm still a bit confused by what you're attempting to do here. Unless I'm missing someting, clocks are properties of the device, not the pm-domain...
> qmss: qmss@2a40000 { > compatible = "ti,keystone-navigator-qmss"; > dma-coherent; > @@ -65,6 +72,8 @@ > #size-cells = <1>; > clocks = <&chipclk13>; > ranges; > + power-domains = <&qmss_domain>;
... Also, each of the pm domains is duplicating the list of clocks from the device node, so I'm not sure what this is accomplishing.
Why not just have a single, more generic power domain that gets the list of clocks from the device node.
Kevin
| |