lkml.org 
[lkml]   [2014]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] rcu: Add sparse check for RCU_INIT_POINTER()
On Thu, Sep 25, 2014 at 02:03:34PM -0400, Pranith Kumar wrote:
> Add a sparse check when RCU_INIT_POINTER() is used to assign a non __rcu
> annotated pointer.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>

Have you checked if this introduces a significant number of new warnings
in the kernel?

If not:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> include/linux/rcupdate.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index a4a819f..a033d8b 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -1047,6 +1047,7 @@ static inline notrace void rcu_read_unlock_sched_notrace(void)
> */
> #define RCU_INIT_POINTER(p, v) \
> do { \
> + rcu_dereference_sparse(p, __rcu); \
> p = RCU_INITIALIZER(v); \
> } while (0)
>
> --
> 2.1.0
>


\
 
 \ /
  Last update: 2014-09-25 20:41    [W:0.033 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site