Messages in this thread | | | Date | Thu, 25 Sep 2014 21:46:00 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] net_dma: fix memory leak in dma_pin_iocvec_pages |
| |
On Tue, Sep 23, 2014 at 11:27:06PM -0700, Dan Williams wrote: > On Tue, Sep 23, 2014 at 9:57 PM, Vinod Koul <vinod.koul@intel.com> wrote: > > On Wed, Sep 03, 2014 at 01:28:59PM +0400, Roman Gushchin wrote: > >> dma_pin_iovec_pages() calls get_user_pages() for each iovec. If > >> get_user_pages() returns a number smaller than the requested number, > >> dma_pin_iovec_pages() calls dma_unpin_iovec_pages(). It releases > >> previously allocated iovecs, but pages pinned by last get_user_pages() > >> call remain unreleased. > >> Fix this by calling put_page() for each such page. > >> > > Applied, thanks > > Vinod, I have a patch in my queue that completely removes the remnants > of NET_DMA. It's been deprecated for more than a few cycles now > without any reports to reinstate it. Time to push the final removal > patch. I'll rebase it on top of this so it doesn't collide.
Okay, thanks for update. If you wnat I can remove it, so you don't need to rebase.
-- ~Vinod
| |