lkml.org 
[lkml]   [2014]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] vfs: fix linkat error for unprivileged AT_EMPTY_PATH
From
On Wed, Sep 24, 2014 at 9:00 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, Sep 24, 2014 at 05:25:23PM +0200, Miklos Szeredi wrote:
>> From: Miklos Szeredi <mszeredi@suse.cz>
>>
>> Return proper error value for linkat(..., AT_EMPTY_PATH) without enough
>> privileges.
>>
>> I guess ENOENT was used here, because without AT_EMPTY_PATH that's what
>> we'd return for an empty path. But it is wrong for AT_EMPTY_PATH, since we
>> might not even be passing an empty path, we are simply complaining about
>> lack of privs for which EPERM is the proper error.
>
> Umm... Are you sure that nothing in userland is checking for that
> return value? I agree that EPERM would make more sense, but...

How could I be sure?

But does it even make sense to check for that error value? I don't
think it is, since we have never allowed unprivileged AT_EMPTY_PATH
for linkat (except by bb2314b4799649 which was reverted before being
included in a release).

So if when (if ever) we do allow that, *then* testing for an error
value will make sense. But surely if one is writing code which can't
even be tested, then it won't come as a big surprise if it will
eventually fail...

Thanks,
Miklos


\
 
 \ /
  Last update: 2014-09-25 17:01    [W:0.080 / U:2.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site