Messages in this thread | | | Date | Thu, 25 Sep 2014 10:58:58 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v4 01/10] tools/perf: support parsing parameterized events |
| |
On Wed, Sep 24, 2014 at 12:27:15PM -0700, Sukadev Bhattiprolu wrote: > From: Cody P Schafer <cody@linux.vnet.ibm.com> > > Enable event specification like: > > pmu/event_name,param1=0x1,param2=0x4/ > > Assuming that > > /sys/bus/event_source/devices/pmu/events/event_name > > Contains something like > > param2=foo,bar=1,param1=baz
hum, so what happened to the '?' ... AFAIU from out last discussion, you wanted to mark terms which are mandatory and user must provide values for them.. and I thought the decision was to have following alias record:
$ cat /sys/bus/event_source/devices/pmu/events/event_name param2=?,bar=1,param1=?
while perf would scream if any of param1/2 wasnt filled like for: pmu/event_name,param1=0x1/
thanks, jirka
| |