| Date | Wed, 24 Sep 2014 10:53:20 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v1 03/12] tpm: TPM2 support for tpm_pcr_read() |
| |
On Wed, Sep 24, 2014 at 12:05:53PM +0300, Jarkko Sakkinen wrote:
> +static struct tpm_input_header tpm2_pcrread_header = {
Missing const - all of these static structures in tpm2-cmds.c are missing the const, please fix them all.
> + .tag = cpu_to_be16(TPM2_ST_NO_SESSIONS), > + .length = cpu_to_be32(TPM2_PCR_READ_IN_SIZE), > + .ordinal = cpu_to_be32(TPM2_CC_PCR_READ) > +};
BTW, I always thought this was a goofy and very expensive way to store 3 values and zero initialize. If you want to do something different in the tpm2-cmds.c that would be great too...
Jason
|