lkml.org 
[lkml]   [2014]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mptfusion: enable no_write_same for vmware scsi disks
Hi Chris,

thanks for updating it, althugh it would need a few more updates.

> + /* Fix for vmware guests that do not implement write_same
> + */
> + if (pdev->subsystem_vendor == 0x15AD) {
> + mptspi_driver_template.no_write_same = 1;
> + }
> +

We should set it only on th host that matches, not the whole template
for this case. The host is allocated just below your statement in
the same function, so this should be easy.

Also no need for braces here, and try to follow the Linux comment style:

/* The VMWare emulation doesn't properly impement WRITE SAME */
if (pdev->subsystem_vendor == 0x15AD)
sh->no_write_same = 1;


(and yes, it would be good to have PCI_VENDOR_ID_VMWARE in pci_ids.h,
but that shouldn't be done in this bug fix patch)


\
 
 \ /
  Last update: 2014-09-23 09:41    [W:0.070 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site